"When You're Smiling" is a song by Larry Shay

Larry Shay

Larry Shay was an American songwriter.Shay was born in Chicago, Illinois. While still young, he studied the piano at the Bush Conservatory of Music in Chicago. He eventually moved to New York City to become a songwriter. His first composition was "Do You, Don't You, Will You, Won't You," published...

, Mark Fisher

Mark Fisher (songwriter)

Mark Fisher was an American songwriter.He was born in Philadelphia, Pennsylvania.He died in Long Lake or Ingleside, Illinois. Many of his compositions were joint ventures with Joe Goodwin and Larry Shay . Another collaborator was Joe Burke.-External references:*...

, and Joe Goodwin (June 6, 1889 - July 31, 1943), and made famous by Louis Armstrong

Louis Armstrong

Louis Armstrong , nicknamed Satchmo or Pops, was an American jazz trumpeter and singer from New Orleans, Louisiana....

, who recorded it at least three times, in 1929, 1932, and 1956. Duke Ellington

Duke Ellington

Edward Kennedy "Duke" Ellington was an American composer, pianist, and big band leader. Ellington wrote over 1,000 compositions...

 also recorded it several times earlier in his career.

Many other recordings exist, for example those by Studies in Swing

Studies in Swing

The Studies in Swing are a series of four 78 rpm records released individually in 1927, on Parlophone.The titles are:* Studies in Swing No.1: Tiger Rag.* Studies in Swing No.2: The Japanese Sandman....

 No.3, Louis Prima

Louis Prima

Louis Prima was a Sicilian American singer, actor, songwriter, and trumpeter. Prima rode the musical trends of his time, starting with his seven-piece New Orleans style jazz band in the 1920s, then successively leading a swing combo in the 1930s, a big band in the 1940s, a Vegas lounge act in the...

, Frank Sinatra

Frank Sinatra

Francis Albert "Frank" Sinatra was an American singer and actor.Beginning his musical career in the swing era with Harry James and Tommy Dorsey, Sinatra became an unprecedentedly successful solo artist in the early to mid-1940s, after being signed to Columbia Records in 1943. Being the idol of the...

, Nat King Cole

Nat King Cole

Nathaniel Adams Coles , known professionally as Nat King Cole, was an American musician who first came to prominence as a leading jazz pianist. Although an accomplished pianist, he owes most of his popular musical fame to his soft baritone voice, which he used to perform in big band and jazz genres...

 and Patti Page

Patti Page

Clara Ann Fowler , known by her professional name Patti Page, is an American singer, one of the best-known female artists in traditional pop music. She was the best-selling female artist of the 1950s, and has sold over 100 million records...

. Cliff Bruner brought it to the country charts in 1939. It was adopted by Leicester City F.C.

Leicester City F.C.

Leicester City Football Club , also known as The Foxes, is an English professional football club based at the King Power Stadium in Leicester...

 as the club anthem, and can be heard at many of the team's games. In 1961, Judy Garland

Judy Garland

Judy Garland was an American actress and singer. Through a career that spanned 45 of her 47 years and for her renowned contralto voice, she attained international stardom as an actress in musical and dramatic roles, as a recording artist and on the concert stage...

 performed the song at the Judy at Carnegie Hall

Judy at Carnegie Hall

Judy at Carnegie Hall is a two-record live recording of a concert by Judy Garland at Carnegie Hall in New York.This concert appearance, on the night of April 23, 1961, has been called "the greatest night in show business history". Garland's live performances were big successes at the time and her...

 concert. Dean Martin

Dean Martin

Dean Martin was an American singer, film actor, television star and comedian. Martin's hit singles included "Memories Are Made of This", "That's Amore", "Everybody Loves Somebody", "You're Nobody till Somebody Loves You", "Sway", "Volare" and "Ain't That a Kick in the Head?"...

 also sang it, sometimes parodying it as "When You're Drinkin'".

Popular culture

In the film The Lonely Passion of Judith Hearne

The Lonely Passion of Judith Hearne

The Lonely Passion of Judith Hearne is a 1987 drama film made by Handmade Films Ltd. and United British Artists starring Maggie Smith and Bob Hoskins. It was directed by Jack Clayton and produced by Richard Johnson and Peter Nelson with George Harrison and Denis O'Brien as executive producers...

, Judith, played by Maggie Smith

Maggie Smith

Dame Margaret Natalie Smith, DBE , better known as Maggie Smith, is an English film, stage, and television actress who made her stage debut in 1952 and is still performing after 59 years...

 sings the song to herself after a night of drinking.

In the popular sitcom Seinfeld episode The Jimmy, Mel Torme

Mel Tormé

Melvin Howard Tormé , nicknamed The Velvet Fog, was an American musician, known for his jazz singing. He was also a jazz composer and arranger, a drummer, an actor in radio, film, and television, and the author of five books...

 dedicates the song to Kramer

Kramer

-People:*Kramer , a musician and record producer.Fictional* Cosmo Kramer, a character from the American sitcom Seinfeld, usually referred to as just "Kramer".For other people, real or fictional, with the last name of "Kramer", see Kramer...

, who is invited as a VIP to the show because earlier in the episode, he goes to the dentist and gets Novacaine, which ends up causing him to speak in a strong lisp and forces him to drool. He is also wearing vertical leap training shoes, and all together, looks like a mentally challenged person.

It has also been sung by Rachel Berry

Rachel Berry (Glee)

Rachel Berry is a fictional character and de facto female lead from the Fox musical comedy-drama series Glee. The character is portrayed by actress Lea Michele, and has appeared in Glee from its pilot episode, first broadcast on May 19, 2009. Rachel was developed by Glee creators Ryan Murphy, Brad...

 (Lea Michelle), a character on the TV Series Glee

Glee (TV series)

Glee is an American musical comedy-drama television series that airs on Fox in the United States, and on GlobalTV in Canada. It focuses on the high school glee club New Directions competing on the show choir competition circuit, while its members deal with relationships, sexuality and social issues...

, in the episode entitled "Mattress

Mattress (Glee)

"Mattress", also known as "Once Upon a Mattress", is the twelfth episode of the American television series Glee. The episode premiered on the Fox network on December 2, 2009. It was written by series creator Ryan Murphy and directed by Elodie Keene. In "Mattress", the glee club is omitted from the...

".

It was re-released by Jersey Budd, a singer from Leicester who created a version along with members of the Leicester City FC squad at the end of the 2009-10 season.

The version recorded by Louis Armstrong was featured in an advertisement for Apple's new iPhone 4

IPhone 4

The iPhone 4 is a touchscreen slate smartphone developed by Apple Inc. It is the fourth generation iPhone, and successor to the iPhone 3GS. It is particularly marketed for video calling , consumption of media such as books and periodicals, movies, music, and games, and for general web and e-mail...

 in 2010.

The Louis Prima version is featured in the video game Mafia 2.

The Louis Prima version is featured in the movie Find me Guilty, directed by Sidney Lumet.

In the Nickelodeon TV series The Backyardigans

The Backyardigans

The Backyardigans is a Canadian/American 3-D CGI-animated children's TV series, created by Janice Burgess. It features five animal children, who imagine that their backyard becomes an adventure place. It is a coproduction of Treehouse TV, and the Canadian animation studio Nelvana. Debuting on...

, the song's tune was used in an episode titled "It's Great To Be A Ghost!".

An instrumental in the style of the Hot Club of France

Quintette du Hot Club de France

Quintette du Hot Club de France was a jazz group founded in France in 1934 by guitarist Django Reinhardt and violinist Stéphane Grappelli, and active in one form or another until 1948....

 is on the 2009 album 'Small Hotel' by John Etheridge

John Etheridge

John Michael Glyn Etheridge is a British jazz/fusion guitarist associated with the Canterbury Scene....

and Sweet Chorus.